Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(web-twig): Link helper texts and validation texts to inputs to improve accessibility #976

Closed
wants to merge 1 commit into from
Closed

Feat(web-twig): Link helper texts and validation texts to inputs to improve accessibility #976

wants to merge 1 commit into from

Conversation

adamkudrna
Copy link
Contributor

@adamkudrna adamkudrna commented Aug 10, 2023 •
edited
Loading

⚠️ WIP

Affected components:

  • Checkbox
  • FieldGroup
  • FileUploaderInput
  • Radio
  • Select
  • TextFieldBase

@github-actions github-actions bot added the feature New feature or request label Aug 10, 2023
@coveralls
Copy link

coveralls commented Aug 10, 2023 •
edited
Loading

Coverage Status

coverage: 80.15%. remained the same
when pulling 3f1cf22 on feature/twig-link-helper-text-to-inputs
into c30f353 on main.

@adamkudrna adamkudrna mentioned this pull request Aug 10, 2023
Merged
@netlify
Copy link

netlify bot commented Aug 10, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit b1ac746
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/64d50971593dcc0009b4e595

@netlify
Copy link

netlify bot commented Aug 10, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-react canceled.

Name Link
🔨 Latest commit b1ac746
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/64d5097155e6d70008f3eadf

@adamkudrna adamkudrna force-pushed the feature/twig-helper-text branch from 581ae34 to e1b90d1 Compare August 15, 2023 11:24
Base automatically changed from feature/twig-helper-text to main August 15, 2023 11:32
@adamkudrna adamkudrna force-pushed the feature/twig-link-helper-text-to-inputs branch from b1ac746 to 3f1cf22 Compare February 29, 2024 14:51
@netlify Netlify
Copy link

netlify bot commented Feb 29, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit 3f1cf22
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/65e09a065875100009a3626c

@netlify Netlify
Copy link

netlify bot commented Feb 29, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 3f1cf22
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/65e09a06b878290008f3adb7

@netlify Netlify
Copy link

netlify bot commented Feb 29, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 3f1cf22
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/65e09a06d07beb0008c6c486

@netlify Netlify
Copy link

netlify bot commented Feb 29, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-react canceled.

Name Link
🔨 Latest commit 3f1cf22
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/65e09a060c368400084fb995

@adamkudrna
Copy link
Contributor Author

Rebased against current main.

@literat
Copy link
Collaborator

literat commented Jun 12, 2024

Didn't we do this (partly) in #1470?

@adamkudrna
Copy link
Contributor Author

Superseded by #1470.

@adamkudrna adamkudrna closed this Jun 25, 2024
@adamkudrna adamkudrna deleted the feature/twig-link-helper-text-to-inputs branch June 25, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@literat literat Awaiting requested review from literat literat will be requested when the pull request is marked ready for review literat is a code owner

@crishpeen crishpeen Awaiting requested review from crishpeen crishpeen will be requested when the pull request is marked ready for review crishpeen is a code owner

@pavelklibani pavelklibani Awaiting requested review from pavelklibani pavelklibani will be requested when the pull request is marked ready for review pavelklibani is a code owner

Assignees

@adamkudrna adamkudrna

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamkudrna @coveralls @literat